gulp build: support esm #32926
gulp build: support esm #32926
Conversation
samouri
requested review from
danielrozenberg and
rsimha
and removed request for
rileyajones
| @@ -100,6 +100,7 @@ build.flags = { | |||
| coverage: ' Adds code coverage instrumentation to JS files using istanbul.', | |||
| version_override: ' Overrides the version written to AMP_CONFIG', | |||
| watch: ' Watches for changes in files, re-builds when detected', | |||
| esm: ' Do not transpile down to ES5', | |||
There was a problem hiding this comment.
I think we need to consume argv.esm in the call to esbuild, right? IIRC, @jridgewell tried doing this in e1c028c (#32699) and had to revert in 85ab0b8 (#32699).
There was a problem hiding this comment.
ah! that is different. that is about literally outputting esmodules, as opposed to what we call "esm build", which simply reduces transpilation.
There was a problem hiding this comment.
For reference, the unminified dist build goes from 799K to 770K with the --esm flag. I'll further reduce it right now.
There was a problem hiding this comment.
I've reduced the transpilation further to align better with what we do in --compiled mode. Now it is down to 754K, and should be even faster to run :)
There was a problem hiding this comment.
Aha, I now see. This gets babel to do something different because of argv.esm, while esbuild does its regular thing.
summary
Allow
gulp buildto process--esmmode. This aligns it with dist build's definition of esm mode (less transpilation, and fewer polyfills).Note: esbuild still outputs an IIFE and not
esm. this is intentional and controlled via the format option.