Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Add support for multiple (comma-separated) --target files for gulp prepend-global #32927

Merged
merged 2 commits into from Feb 26, 2021
Merged

🏗 Add support for multiple (comma-separated) --target files for gulp prepend-global #32927

merged 2 commits into from Feb 26, 2021

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Feb 25, 2021 •
edited

Other changes:

  • Remove unused legacy code that uses allows setting --target via an environment variable
  • Get config file directly from the requested branch without checking it out into the filesystem
    • Remove unexpected behaviour where a missing config file in the requested branch defaults to using the local branch's copy of the file
  • Do not export functions that aren't used anywhere else
  • Ensure only one of --prod or --canary can be passed
  • Fix Promise return types

@amp-owners-bot
Copy link

Hey @rsimha! These files were changed:

build-system/pr-check/module-tests.js
build-system/pr-check/nomodule-tests.js

rsimha
rsimha reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! A few comments below.

build-system/pr-check/module-tests.js Show resolved Hide resolved
build-system/pr-check/module-tests.js Show resolved Hide resolved
build-system/pr-check/nomodule-tests.js Show resolved Hide resolved
build-system/tasks/prepend-global/index.js Show resolved Hide resolved
build-system/tasks/prepend-global/index.js Show resolved Hide resolved
@rsimha rsimha mentioned this pull request Feb 25, 2021
Merged
@danielrozenberg
Copy link
Member Author

Bump

rsimha
rsimha approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

build-system/pr-check/nomodule-tests.js Show resolved Hide resolved
build-system/tasks/prepend-global/index.js Show resolved Hide resolved
@danielrozenberg danielrozenberg merged commit b90b410 into ampproject:master Feb 26, 2021
@danielrozenberg danielrozenberg deleted the prepend-global-multiple branch February 26, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielrozenberg @rsimha @ampprojectbot