New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃彈 Matrixify Experiment Build/Tests on CircleCI #32932
Conversation
Hey @rsimha! These files were changed:
|
Nice exploration! Unfortunately the additional cost probably makes this not worth it. A few reasons:
Alternative challenge: If we can bring down the running time of package installs from ~1 min to a few seconds (I'm working on this), |
ok! So I'll revert the 2nd commit for this PR and keep it around in case we improve the overhead enough to make it worth it |
3e93eb5
to
0ddcbcb
Compare
Done, PTAL |
946ab6a
to
3e1058a
Compare
3e1058a
to
4a8976d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憦馃憦馃憦 LGTM! (I'm kind of disappointed in myself that I didn't do it this way to begin with.)
Hey, you switched an entire CI system... figuring out the subtleties comes later ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL You could do this!
This PR does DRY