Fix unit tests for amp-viewer-integration #32937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Feb 25, 2021
| const event = { | ||
| source: window, | ||
| source: env.win, |
There was a problem hiding this comment.
I love this change. It prevents the pollution of the global window object.
micajuine-ho
approved these changes
Feb 26, 2021
| const ampDocSrc = '/test/fixtures/served/ampdoc-with-messaging.html'; | ||
| // TODO(aghassemi): Investigate failure in beforeEach. #10974. |
There was a problem hiding this comment.
Was there a failure in the beforeEach?
There was a problem hiding this comment.
Not really, not sure why this was skipped (issue #10974 doesn't offer much context).
However, while looking into this, I discovered that 'should handle unload correctly' test was incorrect and got a chance to fix it & move it to the correct location since it is testing AmpViewerIntegration. So thanks for this comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32938