New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃彈 Use new key for storage #32939
馃彈 Use new key for storage #32939
Conversation
Hey @rsimha! These files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
@@ -35,11 +35,11 @@ echo $(GREEN "Setting up Cloud SDK environment...") | |||
(set -x && echo "source ~/google-cloud-sdk/path.bash.inc" >> $BASH_ENV) | |||
source $BASH_ENV | |||
|
|||
echo $(GREEN "Extracting credentials...") | |||
openssl aes-256-cbc -k $GCP_TOKEN -in ./build-system/common/sa-travis-key.json.enc -out sa-travis-key.json -d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see this go away!
|
||
echo $(GREEN "Authenticating with GCP storage...") | ||
gcloud auth activate-service-account --key-file=sa-travis-key.json | ||
gcloud auth activate-service-account --key-file=storage-key.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, logs are less noisy than before: https://app.circleci.com/pipelines/github/ampproject/amphtml/2973/workflows/ef569347-0472-48d6-aba3-86fddf2a168e/jobs/34847/parallel-runs/0/steps/0-104
Any idea how to get rid of the access warning and the survey messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got rid of a few, not the survey though.
Once merged, I'll delete GCP_TOKEN from CircleCI settings