Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [amp-delight-player] Add more unit tests to improve coverage. #32950

Merged
merged 1 commit into from Mar 2, 2021
Merged

✅ [amp-delight-player] Add more unit tests to improve coverage. #32950

merged 1 commit into from Mar 2, 2021

Conversation

rbeckthomas
Copy link
Contributor

Fixes #32949

This change increases code coverage in amp-delight-player from 47.67% to 66.28%
(Measured using the --coverage flag with gulp-unit)

@amp-owners-bot
Copy link

Hey @alanorozco! These files were changed:

extensions/amp-delight-player/0.1/test/test-amp-delight-player.js

@alanorozco alanorozco merged commit 131deac into ampproject:master Mar 2, 2021
@rbeckthomas rbeckthomas deleted the fixit-delight-player branch March 5, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase unit test coverage of [amp-delight-player]
3 participants
@rbeckthomas @alanorozco @ampprojectbot