New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amp-video] ♿ override aria-label with alt #32963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentioned alt
is not valid HTML but valid AMP. The correct HTML way for publishers would be to add either title
or aria-label
.
aria-label
is already propagated to the<video>
element, buttitle
is not, we should fix this- propagating
alt
asaria-label
sounds good as a fallback if notitle
oraria-label
was already provided
Hey @rsimha! These files were changed:
Hey @estherkim! These files were changed:
Hey @danielrozenberg! These files were changed:
Hey @gmajoulet, @newmuis! These files were changed:
Hey @Enriqe! These files were changed:
|
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
a6a293e
to
4ebeba6
Compare
amp-video
acceptsalt
but it's not being read by screen readers.On a video element, screen readers will read
aria-label
but notalt
.alt
asaria-label
ifaria-label
andtitle
is not specifiedContributes to #32493