🏗 Update how to execute jscodeshift

[alanorozco]

I'm not sure if something has changed, but transforms I've run locally have failed lately due to configuration issues. Copied default options, plus importAssertions.

[rsimha]

LGTM with a question. (Feel free to punt if this is blocking development.)

Instead of explicitly copy-pasting the default configs here and having to maintain this file when things change, is there a way to say this config file extends whatever is default?

[alanorozco]

Instead of explicitly copy-pasting the default configs here and having to maintain this file when things change, is there a way to say this config file extends whatever is default?

No, I looked but couldn't find that. It doesn't seem like jscodeshift's config resolution is as sophisticated as Babel's.

[rsimha]

No, I looked but couldn't find that. It doesn't seem like jscodeshift's config resolution is as sophisticated as Babel's.

I see. This might've changed in a recent release: https://github.com/facebook/jscodeshift/releases

The reason we didn't detect it as a breaking change is because we haven't version locked jscodeshift, and are instead, invoking it via npx:

amphtml/build-system/tasks/sweep-experiments/index.js

Lines 101 to 110 in cde4736

	const jscodeshift = (transform, args = []) =>
	getStdoutThrowOnError(
	[
	'npx jscodeshift',
	'--parser babylon',
	`--parser-config ${__dirname}/jscodeshift/parser-config.json`,
	`--transform ${__dirname}/jscodeshift/${transform}`,
	...args,
	].join(' ')
	);

I'm not opposed to your adding it as a dependency and switching to the API instead of the CLI: https://www.npmjs.com/package/jscodeshift#the-jscodeshift-api. With this, we'll get a renovate PR for every new version, and we can preemptively detect and fix breaking changes.

[alanorozco]

The jscodeshift api refers to the object passed in a transform's implementation, not the Runner itself. The Runner doesn't seem to be intentionally accessible, but some do use it. However, it didn't work for me.

This shouldn't be an issue for versioning though. npx jscodeshift will use the local copy if added to package.json.

1. Added dependency to package.json.
2. Moved to build-system/jscodeshift/parser-config.json so it can be shared. (mainly with 🏗 Collect z-index from JS files #32847)

[rsimha]

LGTM after moving the config dir into test-configs/. (See comment below.)

This shouldn't be an issue for versioning though. npx jscodeshift will use the local copy if added to package.json

Excellent, this works too.