馃枍 Bento: Move Selector to JSS #33018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Mar 2, 2021
dvoytenko
suggested changes
Mar 3, 2021
| const optionProps = { | ||
| ...rest, | ||
| className: objstr({ | ||
| [classes.option]: true, | ||
| [classes.selected]: isSelected && !selectorMultiple, |
There was a problem hiding this comment.
I kind of prefer this way, but just calling out that "selected" styles were only set when not disabled before. So just confirming this change is intended.
There was a problem hiding this comment.
Yes, thanks for calling this out explicitly. I'll add it to the PR description as well. Also preferred this way and intended to do this, hence why the relevant test cases were modified as well. This is more consistent with AMP layer this way.
dvoytenko
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to moving CSS to JSS for the
Selectorcomponent, this PR also:selectedanddisabledstate, thereby aligning closer to the AMP layerobj-strforclassNamecomputationRelated to #28282