Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Fix e2e test for collapsed amp-accordion #33064

Merged
merged 1 commit into from Mar 4, 2021
Merged

✅ Fix e2e test for collapsed amp-accordion #33064

merged 1 commit into from Mar 4, 2021

Conversation

caroqliu
Copy link
Contributor

@caroqliu caroqliu commented Mar 4, 2021 •
edited

Appears to be flaky in master due to async expect of the incorrect value (which is sometimes met during size transition).

@caroqliu caroqliu requested a review from krdwan March 4, 2021 15:54
krdwan
krdwan approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@krdwan krdwan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Caroline for the quick fix on this!

@caroqliu caroqliu merged commit 8c2720a into ampproject:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krdwan krdwan krdwan approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caroqliu @krdwan @ampprojectbot