✨ [Story video] Run sortSources/load only if hasLowerBitrate #33065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszylkowski
changed the title
mszylkowski
changed the title
gmajoulet
reviewed
Mar 11, 2021
gmajoulet
approved these changes
Mar 25, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
…ect#33065) * Hide sortSources behind hasLowerBitrate * Fix call * Added test * Run flexible-bitrate * Updated codestyle for comments * Added test for not loading * Linted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32731
Do not call
sortSourcesorloadif the video doesn't have a lower bitrate video.This applies to
updateOtherManagedAndPausedVideosince the other calls tosortSourcesalready check for lower bitrates before sorting