Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Lazy-require babel configs #33072

Merged
merged 1 commit into from Mar 4, 2021
Merged

馃彈 Lazy-require babel configs #33072

merged 1 commit into from Mar 4, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Mar 4, 2021

Two changes:

  • When a babel caller loads babel.config.js, lazy-require and return only the config requested.
  • Remove build-system/ deps from babel.config.js to eliminate side-effects when an empty config is returned.

@rsimha rsimha self-assigned this Mar 4, 2021
@rsimha rsimha merged commit 8e71cdf into ampproject:master Mar 4, 2021
@rsimha rsimha deleted the 2021-03-04-LazyBabelConfig branch March 4, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@rcebulko rcebulko rcebulko approved these changes

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rsimha @jridgewell @rcebulko @ampprojectbot