Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Panning media] Prevent returning infinity in zoom #33073

Merged
merged 6 commits into from
Mar 16, 2021

Conversation

processprocess
Copy link
Contributor

Adds calculateZoom_ method that:

  • Calculates zoom for translate3d
  • Ensures number is finite

Context / Fixes #33071

@amp-owners-bot
Copy link

amp-owners-bot bot commented Mar 4, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story-panning-media/0.1/amp-story-panning-media.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Panning media] handle zoom value being 0
5 participants