🏗 ♻️ Fix type errors in /build-system/tasks #33074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
force-pushed
the
tsc
branch
5 times, most recently
from
3beffc2
to
280162a
Compare
rileyajones
commented
Mar 4, 2021
| @@ -241,8 +241,8 @@ const findConfigBitCommits = ( | |||
| tokens.pop(); | |||
| } | |||
| return { | |||
| hash: tokens.shift(), | |||
| authorDate: tokens.shift(), | |||
| hash: /** @type {string} */ (tokens.shift()), | |||
There was a problem hiding this comment.
Unlike my the other comment I left about string.split.shift this could technically be undefined but I trust that the @alanorozco understands this code better than I.
There was a problem hiding this comment.
Sorry, I had this missed this question!
This seems fine per format received: %h %aI %s, though we have the conditional .pop() above. I'd say this is good but I'll make a separate change to put up a guard before this cast.
There was a problem hiding this comment.
#33266 for safer parsing/testing
There was a problem hiding this comment.
Thanks @alanorozco
rileyajones
force-pushed
the
tsc
branch
2 times, most recently
from
eab7343
to
b982744
Compare
|
Hey @erwinmombay, @jridgewell! These files were changed: Hey @rsimha! These files were changed: Hey @alanorozco! These files were changed: Hey @estherkim! These files were changed: |
estherkim
reviewed
Mar 5, 2021
rsimha
reviewed
Mar 5, 2021
rileyajones
force-pushed
the
tsc
branch
7 times, most recently
from
e773e2b
to
9740f77
Compare
rsimha
reviewed
Mar 11, 2021
ghost
approved these changes
Mar 11, 2021
ghost
approved these changes
Mar 11, 2021
rileyajones
force-pushed
the
tsc
branch
2 times, most recently
from
ddf5ae5
to
99f4bea
Compare
estherkim
reviewed
Mar 15, 2021
rileyajones
force-pushed
the
tsc
branch
3 times, most recently
from
9e3da81
to
581540e
Compare
estherkim
approved these changes
Mar 17, 2021
Co-authored-by: Raghu Simha <rsimha@amp.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ongoing effort to add typing to the build-system directory has finally reached the largest directory "tasks". Due to the large size of this directory the e2e, performance, and visual-diff subdirectories have been excluded from this PR but will be fixed in another upcoming PR.
The total number of type errors within the /build-system/tasks directory was 544 which combined with the additional 6 outstanding summed to 550.
After this PR there will be a total of 281 and without the e2e, performance, and visual-diff directories the number drops to 15.
#28387