✨ [Story bookend] Created amp-story-social-share #33077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
honeybadgerdontcare
approved these changes
Mar 4, 2021
gmajoulet
approved these changes
Mar 12, 2021
processprocess
pushed a commit
to processprocess/amphtml
that referenced
this pull request
Mar 17, 2021
* Created social-share * Remove empty social share extension * Fixed validation * Updated validation * Updated validation rule to pass test * Remove comment * Updated tests * Added tests
MichaelRybak
pushed a commit
to MichaelRybak/amphtml
that referenced
this pull request
Mar 18, 2021
Merged
MichaelRybak
added a commit
that referenced
this pull request
Mar 18, 2021
cl/363456177 Revision bump for #33077 @Gregable authored and @MichaelRybak committed cl/363067094 Allow link rel=modulepreload in AMP @honeybadgerdontcare authored and @MichaelRybak committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #26957
Part of the deprecation of the bookend is to create a substitute, which will allow creators to specify the share providers in a separate component.
Steps in this PR:
amp-story-social-shareas a validated tag where the configuration can be added.loadShareConfiginstead ofcallBookendConfigwhen deciding what the social share providers will be. This falls back onloadBookendConfigif there is noamp-story-social-sharetag present in the story.amp-story-social-shareas a valid tag that can have a script inside it or the src attribute.