Do not install extensions twice in multidoc #33084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #33001.
For some reason, the multidoc is installing extensions twice. In reality they only install once since the extension service checks whether or not an extension has been installed. But there's no reason to do it twice. More importantly, the first call is more precise because it includes the correct version.
The first call is inside the
mergeHead_
:amphtml/src/multidoc-manager.js
Lines 442 to 446 in 472974b
The second call is done right after the
mergeHead_
:amphtml/src/multidoc-manager.js
Line 242 in 472974b