Multi-version: always specify version when waiting for an extension #33226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
force-pushed
the
bento/ext-version-waitfor
branch
from
00d304e
to
d89a6b8
Compare
jridgewell
reviewed
Mar 15, 2021
jridgewell
approved these changes
Mar 16, 2021
dvoytenko
force-pushed
the
bento/ext-version-waitfor
branch
from
16cc18d
to
fc44ce4
Compare
processprocess
pushed a commit
to processprocess/amphtml
that referenced
this pull request
Mar 17, 2021
…mpproject#33226) * Multi-version: always specify version when waiting for an extension * fix some tests * runtime tests * test-element-service.js * test-url-replacements fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #33020.
With ampdoc services the version is declared on the document itself. With global services the version has to be provided explicitly.
TODO: