Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Local Media Consortium: Endpoint rename to NewsPassID #33255

Merged
merged 1 commit into from
Mar 18, 2021
Merged

✨ Local Media Consortium: Endpoint rename to NewsPassID #33255

merged 1 commit into from
Mar 18, 2021

Conversation

greg-silvermine
Copy link
Contributor

No description provided.

@amp-owners-bot amp-owners-bot bot requested a review from lannka March 15, 2021 09:31
@greg-silvermine
Copy link
Contributor Author

Hi @lannka!

It's just a RTC endpoint name change.
Could you please approve that one so that it could go into release alongside with #33004 if possible?

Great thanks in advance!

@greg-silvermine
Copy link
Contributor Author

Rebased to most recent one upstream/master.

@greg-silvermine
Copy link
Contributor Author

Hi @lannka or @calebcordry. Could you please take a look at this PR. It's very straight forward change. Appreciate it! Thanks!

calebcordry
calebcordry approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining this!

@calebcordry calebcordry merged commit effb945 into ampproject:master Mar 18, 2021
@greg-silvermine
Copy link
Contributor Author

Thanks, @calebcordry! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

@lannka lannka Awaiting requested review from lannka

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greg-silvermine @calebcordry @ampprojectbot