🏗 Remove Compute Merge Commit as a direct CircleCI job dependency where it's already a transitive dependency
#33268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
requested review from
rsimha and
jridgewell
and removed request for
rsimha
|
Hey @rsimha! These files were changed: |
rsimha
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Agree, the visualization does look prettier and easier to understand 😃
@jridgewell Any concerns with checking this in?
PS: PR description with the side-by-side screenshots is also pretty and easy to understand!
rsimha
reviewed
Mar 15, 2021
kristoferbaxter
approved these changes
Mar 15, 2021
…re it's already a transitive dependency
danielrozenberg
force-pushed
the
no-second-level-deps
branch
from
e40f6f2
to
b4a2ef2
Compare
jridgewell
approved these changes
Mar 15, 2021
processprocess
pushed a commit
to processprocess/amphtml
that referenced
this pull request
Mar 17, 2021
…here it's already a transitive dependency (ampproject#33268)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just think it makes the graph look better 😅