Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky amp-base-carousel 1.0 tests #33269

Merged
merged 9 commits into from
Mar 15, 2021

Conversation

caroqliu
Copy link
Contributor

Related to #24195

Skips all offenders below:
image

cc @samouri

@caroqliu
Copy link
Contributor Author

Merging since ExpA tests appeared to have succeeded even though the build matrix entry for it is behind.

@caroqliu caroqliu merged commit ca503aa into ampproject:master Mar 15, 2021
@calebcordry
Copy link
Member

calebcordry commented Mar 15, 2021

I think some of these might have been skipped in the 0.1 file? I still see a 1.0 failure for should render correctly after pulling in this change. e.g. https://app.circleci.com/pipelines/github/ampproject/amphtml/4568/workflows/047da406-713c-4856-8a45-0d5b944379d9/jobs/59727

@caroqliu
Copy link
Contributor Author

I think some of these might have been skipped in the 0.1 file? I still see a 1.0 failure for should render correctly after pulling in this change. e.g. https://app.circleci.com/pipelines/github/ampproject/amphtml/4568/workflows/047da406-713c-4856-8a45-0d5b944379d9/jobs/59727

Good catch, thank you! Fixed in #33290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants