Apply visibility: hidden to carousel spacers in amp-carousel 0.2 #33279
Conversation
|
Thanks for this!
I only see the addition of |
Nope. The description is saying that |
| @@ -57,17 +57,17 @@ | |||
| * calculating the 100% height (or width) of the slide. | |||
| */ | |||
| /* Firefox */ | |||
| .i-amphtml-carousel-scroll[hide-scrollbar="true"] { | |||
| scrollbar-width: none; | |||
| .i-amphtml-carousel-scroll[hide-scrollbar='true'] { | |||
There was a problem hiding this comment.
This change appears unrelated, was this from prettier formatting?
There was a problem hiding this comment.
Yea this whole file was formatted in 11b3b3a
| overflow: hidden; | ||
| } | ||
|
|
||
| .i-amphtml-carousel-spacer { | ||
| z-index: -1; | ||
| visibility: hidden; |
There was a problem hiding this comment.
Does this carry an accessibility concern? I can't imagine it does, but just want to verify.
There was a problem hiding this comment.
Confirming there is no impact on accessibility with this change.
Spacer elements are used to establish scroll width / scroll momentum but should not themselves be seen. This change should also save some work in the rendering engine without impacting end user experience.
Impacts
amp-carousel-0.2andamp-base-carousel-0.1.Notes:
content-visibility: hiddenas we will never switch betweenhiddenandvisiblestatesdisplay: noneas these elements should still have size (hence the name "spacer"!)