Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance-impl: use fcp and ofv entryTime when summing for cls-fcp and cls-ofv #33295

Merged
merged 5 commits into from
Mar 17, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Mar 16, 2021

summary

  • All CLS-related events are emitted within the same flush(), at the time when CLS would normally be emitted.
  • cls-fcp and cls-ofv now use the corresponding entryTime for knowing which layout-shifts to include, as opposed to assuming they were invoked synchronously after the corresponding event.
  • In order to accomplish both items above, we now collect all the layout shift events into an array instead of summing as we go. I've added a limit of 1000 entries so that it can't have unbounded growth.

@samouri samouri requested a review from rcebulko March 16, 2021 17:21
@samouri samouri self-assigned this Mar 16, 2021
@samouri samouri marked this pull request as ready for review March 16, 2021 17:32
@samouri
Copy link
Member Author

samouri commented Mar 16, 2021

Note: most of the random-seeming number changes in the tests are reverting the previous PRs changes

Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for addressing quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants