Add Storybook example for amp-twitter:0.1 #33300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caroqliu
force-pushed
the
twitter-storybook
branch
from
e2229a2
to
4dbfaa2
Compare
|
Hey @alanorozco! These files were changed: |
alanorozco
approved these changes
Mar 18, 2021
| @@ -4,7 +4,7 @@ | |||
| "description": "Gulp storybook tasks", | |||
| "main": "index.js", | |||
| "devDependencies": { | |||
| "@ampproject/storybook-addon": "1.1.6", | |||
| "@ampproject/storybook-addon": "^1.1.7", | |||
There was a problem hiding this comment.
Pin dependency.
Suggested change
| "@ampproject/storybook-addon": "^1.1.7", | |
| "@ampproject/storybook-addon": "1.1.7", |
There was a problem hiding this comment.
Thanks for the review! The package.json changes are no longer in this PR since renovate bot beat me to it, so no action here except merging with master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example Storybook for amp-twitter 0.1
cc @dvoytenko