amp-ad-custom: resolve the template in the right context #33324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Mar 17, 2021
calebcordry
reviewed
Mar 17, 2021
calebcordry
approved these changes
Mar 17, 2021
dvoytenko
force-pushed
the
run3/templates-ampdoc-ad-custom-fix
branch
from
7be1de9
to
f1e4795
Compare
rcebulko
pushed a commit
that referenced
this pull request
Mar 17, 2021
* amp-ad-custom: resolve the template in the right context * tests * fix more tests (cherry picked from commit d54e611)
dvoytenko
pushed a commit
to dvoytenko/amphtml
that referenced
this pull request
Mar 17, 2021
…33324) * amp-ad-custom: resolve the template in the right context * tests * fix more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33317.