Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3q-player: implement async pause #33332

Merged
merged 2 commits into from
Mar 18, 2021
Merged

3q-player: implement async pause #33332

merged 2 commits into from
Mar 18, 2021

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Mar 17, 2021 •
edited

This will serve as a template for all similar elements.

Partial for #31915.
Partial for #31540.

@dvoytenko dvoytenko marked this pull request as ready for review March 17, 2021 23:02
@amp-owners-bot
Copy link

Hey @alanorozco! These files were changed:

extensions/amp-3q-player/0.1/amp-3q-player.js
extensions/amp-3q-player/0.1/test/test-amp-3q-player.js

@dvoytenko dvoytenko merged commit 3f1bc68 into ampproject:master Mar 18, 2021
@dvoytenko dvoytenko deleted the run3/pause/3q-player branch March 18, 2021 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@alanorozco alanorozco Awaiting requested review from alanorozco

@samouri samouri Awaiting requested review from samouri

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @jridgewell @ampprojectbot