Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Marfeel: Update CMP config #33350

Merged

Conversation

oscarmarimrf
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to check these changes locally, since your server returns consentRequired: false. Have you confirmed that these changes are good?

@oscarmarimrf
Copy link
Contributor Author

I was not able to check these changes locally, since your server returns consentRequired: false. Have you confirmed that these changes are good?

Yes, we have doublechecked that everything works as expected, the endpoint is returning consentRequired: true only for some geos. Thanks @micajuine-ho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants