Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bento: adopt mount/unmount #33367

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Bento: adopt mount/unmount #33367

merged 3 commits into from
Mar 25, 2021

Conversation

dvoytenko
Copy link
Contributor

Partial for #30952.

samouri
samouri approved these changes Mar 19, 2021
View reviewed changes
test/unit/test-custom-element-v1.js Outdated Show resolved Hide resolved
jridgewell
jridgewell approved these changes Mar 25, 2021
View reviewed changes
src/preact/base-element.js Show resolved Hide resolved
@dvoytenko dvoytenko merged commit 1ebbd3b into ampproject:master Mar 25, 2021
@dvoytenko dvoytenko deleted the bento/mount branch March 25, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@samouri samouri samouri approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dvoytenko @jridgewell @samouri @ampprojectbot