Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Report results for experiment tests #33389

Merged
merged 1 commit into from
Mar 19, 2021
Merged

馃彈 Report results for experiment tests #33389

merged 1 commit into from
Mar 19, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Mar 19, 2021

PR Highlights:

  • Adds test case reporting for experiment builds
  • Fixes job ID extraction (turns out that CIRCLE_NODE_INDEX is always zero, so use CIRCLE_JOB instead)

Reference: https://circleci.com/docs/2.0/env-vars/

@rsimha rsimha self-assigned this Mar 19, 2021
@rsimha rsimha mentioned this pull request Mar 19, 2021
Merged
@rsimha rsimha merged commit de485f3 into ampproject:master Mar 19, 2021
@rsimha rsimha deleted the 2021-03-19-ReportExperimentTestResults branch March 19, 2021 21:31
@rsimha rsimha mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@rcebulko rcebulko rcebulko approved these changes

@rileyajones rileyajones rileyajones approved these changes

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rsimha @danielrozenberg @rcebulko @rileyajones @ampprojectbot