Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Check some forbidden terms in comments #33485

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

alanorozco
Copy link
Member

Terms can now specify whether they should be checked in comments.

@alanorozco alanorozco requested a review from rsimha March 25, 2021 16:33
@alanorozco alanorozco marked this pull request as ready for review March 25, 2021 16:38
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

build-system/test-configs/forbidden-terms.js Show resolved Hide resolved
@alanorozco alanorozco merged commit 212f4fe into ampproject:master Mar 26, 2021
@alanorozco alanorozco deleted the terms-check-comments branch March 26, 2021 02:11
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Terms can now specify whether they should be checked in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants