Remove measure APIs from amp-auto-lightbox #33663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
force-pushed
the
run3/measure/auto-lightbox
branch
from
4004594
to
80e6783
Compare
jridgewell
approved these changes
Apr 7, 2021
| * @param {!Element} element | ||
| * @return {!Promise<!ClientRect>} | ||
| */ | ||
| export function measure(ampdoc, element) { |
There was a problem hiding this comment.
Should we promote this to src/dom.js?
There was a problem hiding this comment.
Sorry, was going to comment on that and forgot. @samouri has already created src/utils/intersection and I can reuse that. The only nit is that the src/utils/intersection uses an IntersectionObserver{root:document}, which triggers the polyfill path in more cases than a simple {root:null} that I do here. So I wasn't sure if it's worth reusing the existing util or rolling this as a single-use utility for the extension. LMK what you think.
samouri
approved these changes
Apr 7, 2021
I did both: promoted it to |
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Remove measure APIs from amp-auto-lightbox * fix presubmits * moved measurer to src/utils * lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #31540.
Partial for #33678.
This blocks #33649.