New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nend amp-ad support. #3378
Nend amp-ad support. #3378
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
9db3c71
to
9bd1691
Compare
CLAs look good, thanks! |
* @param {!Object} data | ||
*/ | ||
export function nend(global, data) { | ||
global.nendParam = data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the permitted values using checkData
from the 3p
module?
Is data-nend_params
required? If so - could you please verify its existence via validateDataExists
in the same module?
@nend-net This looks great. Just a couple small comments. PTAL. |
eb6fef4
to
5c35bd0
Compare
@dvoytenko |
@nend-net Thanks! Merging. |
@dvoytenko Thanks a lot! |
Could you merge 'Nend amp-ad support' into ampproject/amphtml master branch?
We have a Google Corporate CLA.
Our CLA: F@N Communications, Inc.
Our company name: F@N Communications, Inc.
Thank you in advance