Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nend amp-ad support. #3378

Merged
merged 1 commit into from Jun 1, 2016
Merged

Nend amp-ad support. #3378

merged 1 commit into from Jun 1, 2016

Conversation

nend-net
Copy link
Contributor

Could you merge 'Nend amp-ad support' into ampproject/amphtml master branch?

We have a Google Corporate CLA.
Our CLA: F@N Communications, Inc.
Our company name: F@N Communications, Inc.

Thank you in advance

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@nend-net nend-net force-pushed the master branch 3 times, most recently from 9db3c71 to 9bd1691 Compare May 30, 2016 06:32
@googlebot
Copy link

CLAs look good, thanks!

@dvoytenko dvoytenko self-assigned this May 31, 2016
* @param {!Object} data
*/
export function nend(global, data) {
global.nendParam = data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the permitted values using checkData from the 3p module?

Is data-nend_params required? If so - could you please verify its existence via validateDataExists in the same module?

@dvoytenko
Copy link
Contributor

@nend-net This looks great. Just a couple small comments. PTAL.

@nend-net nend-net force-pushed the master branch 6 times, most recently from eb6fef4 to 5c35bd0 Compare June 1, 2016 09:32
@nend-net
Copy link
Contributor Author

nend-net commented Jun 1, 2016

@dvoytenko
Thank you for your advice. 
I modified the source and pushed to ’nend-net:master' branch a minutes ago.
Could you check my commit again?

@dvoytenko
Copy link
Contributor

@nend-net Thanks! Merging.

@dvoytenko dvoytenko merged commit 291fbb5 into ampproject:master Jun 1, 2016
@nend-net
Copy link
Contributor Author

nend-net commented Jun 2, 2016

@dvoytenko Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants