Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰馃彈 Fix start references for multiple forbidden terms #33992

Merged
merged 1 commit into from
Apr 23, 2021
Merged

馃悰馃彈 Fix start references for multiple forbidden terms #33992

merged 1 commit into from
Apr 23, 2021

Conversation

alanorozco
Copy link
Member

One term is fine:
image

Start references for multiple terms are overridden:
image

This change fixes it:
image

@alanorozco alanorozco requested a review from rsimha April 23, 2021 19:51
rsimha
rsimha approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I assume this will also fix cases of this sort?

Example 1:
image

Example 2:
image

@alanorozco
Copy link
Member Author

@rsimha Exactly!

@alanorozco alanorozco merged commit 509c952 into ampproject:main Apr 23, 2021
@alanorozco alanorozco deleted the fix-no-forbidden-terms-multiple branch April 23, 2021 20:26
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
@alanorozco @rochapablo
馃悰馃彈 Fix start references for multiple forbidden terms (ampproject#33992)
f9c9325 
One term is fine:
https://user-images.githubusercontent.com/254946/115922844-43ef2c00-a432-11eb-962f-2603d51d7f2f.png

Start references for multiple terms are overridden:
https://user-images.githubusercontent.com/254946/115923022-7c8f0580-a432-11eb-8b7a-ba168bb66e2c.png

This change fixes it:
https://user-images.githubusercontent.com/254946/115922923-5a958300-a432-11eb-81d7-505b2241bf32.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanorozco @rsimha @ampprojectbot