Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Add amp validate-html-fixtures to AMP's PR check workflow #33997

Merged
merged 4 commits into from
Apr 24, 2021
Merged

🏗 Add amp validate-html-fixtures to AMP's PR check workflow #33997

merged 4 commits into from
Apr 24, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Apr 23, 2021

PR Highlights:

Note: Here is the full list of validation errors in our HTML fixtures. Fixing all of them will require a gradual team-wide effort.

Screenshots:

Failing check (single file):

image

Failing check (local changes):

image

Passing check:

image
image

Partial fix for #25149

build-system/tasks/validate-html-fixtures.js Outdated Show resolved Hide resolved
@rsimha rsimha requested a review from alanorozco April 23, 2021 22:53
@rsimha rsimha dismissed alanorozco’s stale review April 24, 2021 00:40

jquery is no longer being introduced as a devDependency. Nice catch!

@rsimha rsimha merged commit 11c5506 into ampproject:main Apr 24, 2021
@rsimha rsimha deleted the 2021-04-22-ValidateExamples branch April 24, 2021 00:41
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants