🏗 Add amp validate-html-fixtures
to AMP's PR check workflow
#33997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Highlights:
amp validate-html-fixtures
to validate all AMP test fixturesAMP
,AMP4ADS
, orAMP4EMAIL
)amphtml-validator --html_format <format> <files>
Targets.HTML_FIXTURES
tobuild-targets.js
to trigger the check during CI only when necessaryamp validate-html-fixtures --local_changes
toamp pr-check
for local development (Validation tests for examples and test fixtures #25149 (comment))build-system/test-configs/config.js
(Validation tests for examples and test fixtures #25149 (comment))Note: Here is the full list of validation errors in our HTML fixtures. Fixing all of them will require a gradual team-wide effort.
Screenshots:
Failing check (single file):
Failing check (local changes):
Passing check:
Partial fix for #25149