Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Add make-extension --test to pushBuildWorkflow #34042

Merged
merged 3 commits into from Apr 28, 2021
Merged

馃彈 Add make-extension --test to pushBuildWorkflow #34042

merged 3 commits into from Apr 28, 2021

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco requested a review from rsimha April 27, 2021 20:57
@amp-owners-bot
Copy link

Hey @rsimha! These files were changed:

build-system/pr-check/checks.js

rsimha
rsimha approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

build-system/pr-check/checks.js Outdated Show resolved Hide resolved
@alanorozco alanorozco merged commit e30f24e into ampproject:main Apr 28, 2021
@alanorozco alanorozco deleted the make-extension-test-on-push branch April 28, 2021 02:42
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
@alanorozco @rochapablo
馃彈 Add make-extension --test to pushBuildWorkflow (ampproject#34042)
19c97a8 
Per ampproject#34021 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanorozco @rsimha @ampprojectbot