🐛 Stories: Disable animations when user prefers-reduced-motion
#34081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorozco
commented
Apr 29, 2021
|
Hey @gmajoulet, @newmuis! These files were changed: Hey @processprocess! These files were changed: Hey @Enriqe! These files were changed: |
processprocess
approved these changes
Apr 29, 2021
gmajoulet
requested changes
Apr 29, 2021
gmajoulet
approved these changes
Apr 29, 2021
It's used in vertical rendering and called in |
|
cc @kristoferbaxter for owners approval. |
Enriqe
reviewed
Apr 29, 2021
Enriqe
approved these changes
Apr 29, 2021
kristoferbaxter
approved these changes
Apr 29, 2021
| @@ -26,6 +26,7 @@ import {Services} from '../../../src/services'; | |||
| import {closest, whenUpgradedToCustomElement} from '../../../src/dom'; | |||
| import {deepEquals} from '../../../src/json'; | |||
| import {dev, user} from '../../../src/log'; | |||
| import {prefersReducedMotion} from '../../../src/utils/media-query-props'; | |||
There was a problem hiding this comment.
Nit: Potentially followup with moving this to src/core.
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
…project#34081) Native animations do not run with `prefers-reduced-motion`. Disable the `AnimationManager` altogether so that pre-animation styling is not applied. Elements correctly remain in their end-state when the animation itself doesn't run. Fixes ampproject#34062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native animations will not run with
prefers-reduced-motion. Disable theAnimationManageraltogether so that pre-animation styling is not applied, and elements correctly remain in their end-state.Fixes #34062