✨ ♻️ [amp story] [Page attachments] Pre tap animations #34142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
raxsha
approved these changes
May 3, 2021
| @@ -37,7 +37,7 @@ const CtaAccentElement = { | |||
| * @param {!Element} element | |||
| * @return {!Element} | |||
| */ | |||
| export const buildOpenDefaultAttachmentElement = (element) => | |||
| export const buildOldAttachmentElement = (element) => | |||
There was a problem hiding this comment.
I'm not sure 'Old' is the right name for this. Technically the old UI is still in use in the case of inline attachments that have no images.
There was a problem hiding this comment.
buildOpenInlineAttachmentElement would be the codepath for with and without images with the work in this PR.
The benefit of this is that they can share structure, style and animations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / fixes #33261
Animate pre-tap state of attachment CTA buttons after 1s.
The inline "no image" variation shares animation with the images version and required a structural change, which makes this a good opportunity to refactor.
winfrom from node.Demo