Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Allow auto-merge for low-risk validator upgrades #34214

Merged
merged 2 commits into from May 4, 2021
Merged

馃彈 Allow auto-merge for low-risk validator upgrades #34214

merged 2 commits into from May 4, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented May 4, 2021

Right now, all validator package updates require a manual review from someone in @ampproject/wg-caching. With this PR, low-risk updates to validator devDependecies like the ones in #34205 will be auto-merged if / when all PR checks go green.

@rsimha rsimha self-assigned this May 4, 2021
@amp-owners-bot amp-owners-bot bot requested a review from alin04 May 4, 2021 21:40
@amp-owners-bot
Copy link

amp-owners-bot bot commented May 4, 2021

Hey @ampproject/wg-caching! These files were changed:

validator/OWNERS

@twifkak twifkak requested review from twifkak and removed request for alin04 May 4, 2021 21:41
pattern: '{package.json,package-lock.json}',
owners: [{name: 'ampproject/wg-caching', requestReviews: false}],
pattern: '{package.json,package-lock.json,WORKSPACE}',
owners: [{name: 'ampproject/wg-caching', required: false}],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overrides the required: true on line 7 (only for package.json, package-lock.json, and WORKSPACE).

@rsimha rsimha merged commit 063eef4 into ampproject:main May 4, 2021
@rsimha rsimha deleted the 2021-05-04-ValidatorOwners branch May 4, 2021 21:50
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants