Run index_test.js with ancient crufty nodejs version #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comes with. This should make it easier to use the NodeJS API, command-line
features, and the webui for users who aren't Javascript developers
("I just want to run the command line / web ui on my box.").
|
/cc: @matcarey @honeybadgerdontcare @Gregable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported index.js and index_test.js to v0.10.25, the Node.js version that runs on Ubuntu 14.04 LTS. Unfortunately it doesn't look like the npm package works with this old Node.js version, perhaps due to the use of the at-polymer libraries. But if I use a recent version of Node.js to install the dependencies I can then switch my Node.js version to this ancient version and index_test.js still passes. So I guess we're half-way there, sort of.