✨ Add exco as new type for amp-ad #34613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@kristoferbaxter hello! Is there a possibility you can review this changes in near future? |
|
@dleleko-exco sorry for the delay, could you please rebase again since this has been pending for a while? I think our lint rules have changed slightly. |
calebcordry
requested changes
Aug 6, 2021
3p/vendors/exco.js
Outdated
| */ | ||
|
|
||
| // src/polyfills.js must be the first import. | ||
| import '../polyfills'; |
There was a problem hiding this comment.
we changed these import paths while this was pending, sorry. The new structure should be something like
import '#3p/polyfills';
import {draw3p, init} from '#3p/integration-lib';
import {register} from '#3p/3p';
import {exco} from '#ads/vendors/exco';
ads/vendors/exco.js
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| import {validateData, writeScript} from '../../3p/3p'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new type for amp-ad extension: