Allow XHR Submissions on forms #3483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
| if (this.xhrAction_) { | ||
| this.xhr_.fetchJson(this.xhrAction_, { |
There was a problem hiding this comment.
Probably want to turn on credentials and requireAmpResponseSourceOrigin
|
@cramforce @dvoytenko PTAL |
| /** @const @private {?string} */ | ||
| this.xhrAction_ = this.form_.getAttribute('action-xhr'); | ||
| if (this.xhrAction_) { | ||
| assertHttpsUrl(this.xhrAction_, this.form_, 'action-xhr'); |
There was a problem hiding this comment.
Before doing these checks, we need to resolve xhrAction_ to the full URL. Otherwise we can't test if it starts with https://... is not valid.
There was a problem hiding this comment.
Also, we need to file against the cache/cdn:
- Resolve
form[action]attribute to the absolute URL - Resolve
form[action-xhr]attribute to the absolute URL.
|
LGTM with one fix requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITI: #3343
Writing some tests. Let me know if this looks good!