Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow amp-autocomplete in email format by default #34848

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

caroqliu
Copy link
Contributor

This PR removes the doc-level opt-in flag introduced in #27174, making amp-autocomplete fully valid and fully available in the AMP format by default. Closes #24881. This change is being implemented now as prompted by approval in a recent wg-amp4email meeting.

/cc @ampproject/wg-amp4email @nainar

@caroqliu caroqliu requested a review from zhangsu June 11, 2021 21:03
@amp-owners-bot amp-owners-bot bot requested a review from banaag June 11, 2021 21:03
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jun 11, 2021

Hey @ampproject/wg-caching! These files were changed:

validator/testdata/amp4email_feature_tests/amp-autocomplete.html
validator/testdata/amp4email_feature_tests/amp-autocomplete.out
validator/validator-main.protoascii

@zhangsu
Copy link
Member

zhangsu commented Jun 12, 2021

I reviewed the recent changes to the working group meeting notes but found no mention of this. Was this only only approved verbally but not taken down in the notes?

I was under the impression that mail.ru and Yahoo! Mail still haven't implemented this feature yet, so this feature would only work in Gmail and the current warning would still make sense.

@caroqliu
Copy link
Contributor Author

I reviewed the recent changes to the working group meeting notes but found no mention of this. Was this only only approved verbally but not taken down in the notes?

I was under the impression that mail.ru and Yahoo! Mail still haven't implemented this feature yet, so this feature would only work in Gmail and the current warning would still make sense.

I wasn't in attendance, but let's not do this if we don't have 100% confidence and documented consensus. @nainar will be the point person on bringing this up for the next agenda.

@caroqliu caroqliu changed the title Allow amp-autocomplete in email format by default DO NOT SUBMIT: Allow amp-autocomplete in email format by default Jun 15, 2021
@caroqliu caroqliu changed the title DO NOT SUBMIT: Allow amp-autocomplete in email format by default Allow amp-autocomplete in email format by default Aug 4, 2021
@caroqliu
Copy link
Contributor Author

caroqliu commented Aug 4, 2021

I reviewed the recent changes to the working group meeting notes but found no mention of this. Was this only only approved verbally but not taken down in the notes?
I was under the impression that mail.ru and Yahoo! Mail still haven't implemented this feature yet, so this feature would only work in Gmail and the current warning would still make sense.

I wasn't in attendance, but let's not do this if we don't have 100% confidence and documented consensus. @nainar will be the point person on bringing this up for the next agenda.

This appears to be approved in the July meeting for @ampproject/wg-amp4email, PTAL.

@caroqliu caroqliu requested a review from samouri August 4, 2021 20:56
@caroqliu
Copy link
Contributor Author

caroqliu commented Aug 5, 2021

ping @ampproject/wg-caching for review please 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMP4Email: Support autocomplete
5 participants