✨ [Amp story player] [Desktop panels player] Experiment setup and basic styling #34956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis! These files were changed: |
processprocess
requested review from
rileyajones
and removed request for
rileyajones
gmajoulet
reviewed
Jul 12, 2021
gmajoulet
reviewed
Jul 16, 2021
gmajoulet
approved these changes
Jul 21, 2021
As per discussion: The css for the buttons are in a file that's injected into the shadow dom so this should be okay. |
|
cc @rileyajones for OWNERS (Renamed a CSS file in this PR). |
rileyajones
reviewed
Jul 23, 2021
| @@ -17,7 +17,7 @@ | |||
| import * as ampToolboxCacheUrl from '@ampproject/toolbox-cache-url'; | |||
| import {Messaging} from '@ampproject/viewer-messaging'; | |||
|
|
|||
| // Source for this constant is css/amp-story-player-iframe.css | |||
| // Source for this constant is css/amp-story-player-shadow.css | |||
There was a problem hiding this comment.
Codecov would really like to see some additional tests for AmpStoryPlayer.
Co-authored-by: Riley Jones <78179109+rileyajones@users.noreply.github.com>
Co-authored-by: Riley Jones <78179109+rileyajones@users.noreply.github.com>
rileyajones
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Fixes #34953