Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Core+Types: resource-container-helper, clipboard, getChildJsonConfig, async-input #35138

Merged
merged 14 commits into from Jul 29, 2021
Merged

♻️ Core+Types: resource-container-helper, clipboard, getChildJsonConfig, async-input #35138

merged 14 commits into from Jul 29, 2021

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Jul 7, 2021 •
edited

Part of #34096 and #32693. Clears another non-core exemption for #preact/slot.
Real diff: 970f12a...2d9bdda

@rcebulko rcebulko force-pushed the core-misc branch 2 times, most recently from 0468c9c to 2ea8ed3 Compare July 7, 2021 15:29
@rcebulko rcebulko requested a review from jridgewell July 7, 2021 15:31
@rcebulko rcebulko marked this pull request as ready for review July 7, 2021 15:38
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jul 7, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-request-service.js
extensions/amp-story/1.0/amp-story-share.js
extensions/amp-story/1.0/animation.js

Hey @jridgewell! These files were changed:

src/core/constants/async-input.js
src/core/dom/amp-element.extern.js
src/core/dom/index.js
src/core/dom/resource-container-helper.js
src/core/dom/video/pause-helper.js
src/core/error/index.js
src/core/window/clipboard.js

@rcebulko
Copy link
Contributor Author

@jridgewell bump

1 similar comment
@rcebulko
Copy link
Contributor Author

@jridgewell bump

@rcebulko rcebulko merged commit 3fed670 into ampproject:main Jul 29, 2021
@rcebulko rcebulko deleted the core-misc branch July 29, 2021 20:04
@rcebulko rcebulko mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rcebulko @jridgewell @ampprojectbot