Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use remote video cache over AMP Cache video cache. #35194

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Use remote video cache over AMP Cache video cache. #35194

merged 1 commit into from
Jul 13, 2021

Conversation

gmajoulet
Copy link
Contributor

Use remote video cache over AMP Cache video cache.

Given the following configuration:

<amp-video
  cache="google"
  src="example-com.cdn.ampproject.org.com/foo.mp4"
  amp-orig-src="example.com/foo.mp4"

The cdn.ampproject.org will NO LONGER take precedence, and the cache="google" will be used.

@gmajoulet gmajoulet force-pushed the remote_cache_over_amp_cache branch from 3dfe547 to 60c0541 Compare July 12, 2021 23:10
@gmajoulet gmajoulet added this to In progress in wg-stories Sprint via automation Jul 12, 2021
@gmajoulet gmajoulet merged commit 0fde716 into ampproject:main Jul 13, 2021
wg-stories Sprint automation moved this from In progress to Done Jul 13, 2021
@mszylkowski mszylkowski mentioned this pull request Jul 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszylkowski mszylkowski mszylkowski approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
wg-stories Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmajoulet @mszylkowski @ampprojectbot