✅ ♻️ Reduce default e2e test timeout #35273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @estherkim! These files were changed: Hey @gmajoulet, @newmuis! These files were changed: |
rileyajones
force-pushed
the
shorter-e2e
branch
2 times, most recently
from
96a5cd5
to
56e8365
Compare
danielrozenberg
approved these changes
Jul 21, 2021
rsimha
approved these changes
Jul 21, 2021
rileyajones
force-pushed
the
shorter-e2e
branch
3 times, most recently
from
b1a6c42
to
41b40ff
Compare
rbeckthomas
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing the maximum test timeout (and overriding it in the tests that currently exceeded it) is the first step in preventing new long running tests from being introduced. In the future I would like to disallow usage of
this.timeoutto control newly added slow running tests.