Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Custom Browser Event Tracker End-to-End Test #35354

Merged
merged 13 commits into from
Aug 5, 2021
Merged

✅ Custom Browser Event Tracker End-to-End Test #35354

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9b9b8d5
fixture for cbe
kalemuw Jul 22, 2021
e8779fe
e2e tests
kalemuw Jul 22, 2021
cc46b62
fixed typo
kalemuw Jul 26, 2021
5e1835e
add id to request
kalemuw Jul 28, 2021
3a684be
year change
kalemuw Jul 28, 2021
af1f5f6
Merge branch 'main' into CBE-e2e-test
kalemuw Jul 30, 2021
23462d0
resync changes
kalemuw Jul 30, 2021
4c991c2
resync event.js
kalemuw Jul 30, 2021
468bdcc
renaming
kalemuw Aug 3, 2021
024c016
update events.js
kalemuw Aug 3, 2021
70ad199
Merge branch 'main' into CBE-e2e-test
kalemuw Aug 3, 2021
45f6daa
merge with main branch
kalemuw Aug 4, 2021
bd65945
allow list invalid files
kalemuw Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions extensions/amp-analytics/0.1/test-e2e/test-cbe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,11 @@ describes.endtoend(

// Sleep 1 second for the blur event to be sent
await sleep(1000);
await expect(
'https://foo.com/event?type=blur&eventId='
).to.have.been.sent;
await expect('https://foo.com/event?type=blur&eventId=inputText2').to.have
.been.sent;
});

it('click on dropdown menu to focus and then blur', async () => {

const focusedDropdown = await controller.findElement('#numChild');
const blurredDropdown = await controller.findElement('#numChild2');
kalemuw marked this conversation as resolved.
Show resolved Hide resolved

Expand All @@ -56,9 +54,8 @@ describes.endtoend(

// Sleep 1 second for the blur event to be sent
await sleep(1000);
await expect(
'https://foo.com/event?type=blur&eventId='
).to.have.been.sent;
await expect('https://foo.com/event?type=blur&eventId=numChild2').to.have
.been.sent;
});

it('change the content of the input field to trigger on change event', async () => {
Expand All @@ -71,10 +68,8 @@ describes.endtoend(

// Sleep 1 second for the change event to be sent
await sleep(1000);
await expect(
'https://foo.com/event?type=change&eventId='
).to.have.been.sent;

await expect('https://foo.com/event?type=change&eventId=inputText').to
.have.been.sent;
});

it('change drop down option selected to trigger on change event', async () => {
Expand All @@ -84,11 +79,9 @@ describes.endtoend(
await controller.type(changedDropdown, '1');
await controller.type(changedDropdown, Key.Enter);
// Sleep 1 second for the change event to be sent
await sleep(1000);
await expect(
'https://foo.com/event?type=change&eventId='
).to.have.been.sent;

await sleep(5000);
await expect('https://foo.com/event?type=change&eventId=numChild').to.have
.been.sent;
});
}
);
35 changes: 31 additions & 4 deletions test/fixtures/e2e/amp-analytics/custom-browser-events.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@
<script async custom-element="amp-form" src="https://cdn.ampproject.org/v0/amp-form-0.1.js"></script>
<script async custom-element="amp-analytics" src="https://cdn.ampproject.org/v0/amp-analytics-0.1.js"></script>
<script async src="https://cdn.ampproject.org/v0.js"></script>
<script>
(self.AMP = self.AMP || []).push(function (AMP) {
AMP.toggleExperiment('analytics-browser-events', true);
});
</script>
</head>
<body>
<div style="display: flex; flex-direction: column; height: 100vh">
Expand Down Expand Up @@ -116,23 +121,45 @@ <h1>AMP Form</h1>
"genericTrigger-1":{
"on": "change",
"request": "event",
"selector": ["#inputText","#numChild"],
"selector": "#inputText",
"vars": {
"eventType": "change"
},
"extraUrlParams":{
"eventId": "${id}"
kalemuw marked this conversation as resolved.
Show resolved Hide resolved
"eventId": "inputText"
}
},
"genericTrigger-2":{
"on": "change",
"request": "event",
"selector": "#numChild",
"vars": {
"eventType": "change"
},
"extraUrlParams":{
"eventId": "numChild"
}
},
"genericTrigger-3":{
"on": "blur",
"request": "event",
"selector": "#inputText2",
"vars": {
"eventType": "blur"
},
"extraUrlParams":{
"eventId": "inputText2"
}
},
"genericTrigger-4":{
"on": "blur",
"request": "event",
"selector": ["#inputText2", "#numChild2"],
"selector": "#numChild2",
"vars": {
"eventType": "blur"
},
"extraUrlParams":{
"eventId": "${id}"
"eventId": "numChild2"
}
}
}
Expand Down