Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Amp story player] [Desktop panels player] Hide buttons if full-bleed story. #35397

Merged
merged 8 commits into from Jul 27, 2021

Conversation

processprocess
Copy link
Contributor

Uses story viewer messaging service to listen to ui state update events.
Toggles visibility of the prev and next story buttons on the component based on UI state.
Hides code behind experiment.
Removes old comment.

Jul-26-2021.11-36-04.mp4

@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-viewer-messaging-handler.js

src/amp-story-player/amp-story-player-impl.js Outdated Show resolved Hide resolved
src/amp-story-player/amp-story-player-impl.js Show resolved Hide resolved
src/amp-story-player/amp-story-player-impl.js Outdated Show resolved Hide resolved
src/amp-story-player/amp-story-player-impl.js Outdated Show resolved Hide resolved
@processprocess processprocess added this to In Progress in wg-stories Player Jul 27, 2021
@processprocess processprocess merged commit 192ae58 into ampproject:main Jul 27, 2021
wg-stories Player automation moved this from In Progress to Done Jul 27, 2021
wg-stories Sprint automation moved this from In progress to Done Jul 27, 2021
wg-stories Desktop One Panel automation moved this from In progress to Done Jul 27, 2021
@processprocess processprocess deleted the player-state branch July 27, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants