Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Remove newline from log color definitions in CircleCI bash files #35479

Merged
merged 1 commit into from Jul 30, 2021
Merged

馃彈 Remove newline from log color definitions in CircleCI bash files #35479

merged 1 commit into from Jul 30, 2021

Conversation

danielrozenberg
Copy link
Member

No description provided.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jul 30, 2021 •
edited

Hey @rsimha! These files were changed:

.circleci/check_config.sh
.circleci/get_pr_number.sh
.circleci/maybe_gracefully_halt.sh

rsimha
rsimha approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@danielrozenberg
Copy link
Member Author

Will rebase this after #35475 is merged due to potential merge conflicts

@danielrozenberg danielrozenberg enabled auto-merge (squash) July 30, 2021 20:09
@danielrozenberg danielrozenberg merged commit 933c1ca into ampproject:main Jul 30, 2021
@danielrozenberg danielrozenberg deleted the circleci-no-newline-on-color branch August 2, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielrozenberg @rsimha @ampprojectbot