Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毊 Remove tcf-post-message-proxy-api experiment #35551

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

alanorozco
Copy link
Member

Launched ~5 months ago, getting ahead of the automated removal at the beginning of next month.

Previous history on prod-config.json:

- 1b7583d - 2021-03-12T07:22:55-08:00 - 馃И [amp-consent] Turn on TCF PostMessage Proxy API Experiment
Sweep experiments last flipped globally up to 2021-08-04:

- (2021-03-12, 1b7583d) `tcf-post-message-proxy-api`: 1

---

### 鈿狅笍 Javascript source files require intervention

The following may contain errors and/or require intervention to remove superfluous conditionals:

- [ ] `extensions/amp-consent/0.1/amp-consent.js`
- [ ] `extensions/amp-consent/0.1/test/test-amp-consent.js`

Refer to the removal guide for [suggestions on handling these modified Javascript files.](https://github.com/ampproject/amphtml/blob/main/build-system/tasks/sweep-experiments/README.md#followup)

---

### 鈿狅笍 HTML files may still contain references

The following HTML files contain references to experiment names which may be stale and should be manually removed:

- [ ] `examples/amp-consent/amp-consent-3p-postmessage.html`

Refer to the removal guide for [suggestions on handling these HTML files.](https://github.com/ampproject/amphtml/blob/main/build-system/tasks/sweep-experiments/README.md#followup:html)
@alanorozco alanorozco requested a review from dmanek August 5, 2021 23:45
@amp-owners-bot amp-owners-bot bot requested a review from newmuis August 5, 2021 23:45
@alanorozco alanorozco requested review from kristoferbaxter and removed request for newmuis August 5, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants