Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story interactive] Add slider animations #35557

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

syydneyyhardister
Copy link
Contributor

This adds the hinting animation, before the user interacts with the component. As well as transitions to the slider bubble

Demo: https://sydney-story-demo.web.app/examples/amp-story/interactive_slider.html

@amp-owners-bot amp-owners-bot bot requested a review from gmajoulet August 6, 2021 15:32
@amp-owners-bot
Copy link

amp-owners-bot bot commented Aug 6, 2021

Hey @gmajoulet, @mszylkowski! These files were changed:

extensions/amp-story-interactive/0.1/amp-story-interactive-abstract.js
extensions/amp-story-interactive/0.1/amp-story-interactive-slider.css
extensions/amp-story-interactive/0.1/amp-story-interactive-slider.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-slider.js

@mszylkowski mszylkowski changed the title Animations clean [Story interactive] Add slider animations Aug 6, 2021
@mszylkowski mszylkowski requested review from mszylkowski and processprocess and removed request for gmajoulet August 6, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants